[
https://issues.apache.org/jira/browse/HADOOP-16158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798264#comment-16798264
]
Kai Xie edited comment on HADOOP-16158 at 3/21/19 5:06 PM:
-----------------------------------------------------------
Hi [[email protected]],
the patch (004) is ready for review. when you have time, would you mind taking
a look?
the fix proposed is to add a checksum validation in CopyCommitter when chunks
are concatenated back to one. And the validation can be skipped if the config
skipCrc is set.
I'll also provide a patch for branch-2, since trunk has backward incompatible
changes (in DistCpOptions ctor).
was (Author: kai33):
Hi [[email protected]],
the patch (004) is ready for review. when you have time, would you mind taking
a look?
the fix proposed is to add a checksum validation in CopyCommitter when chunks
are concatenated back to one. And the validation can be skipped if the config
skipCrc is set.
I'll also provide a patch for branch-2, since trunk has backward incompatible
changes.
> DistCp supports checksum validation when copy blocks in parallel
> ----------------------------------------------------------------
>
> Key: HADOOP-16158
> URL: https://issues.apache.org/jira/browse/HADOOP-16158
> Project: Hadoop Common
> Issue Type: Improvement
> Components: tools/distcp
> Affects Versions: 3.2.0, 2.9.2
> Reporter: Kai Xie
> Assignee: Kai Xie
> Priority: Major
> Attachments: HADOOP-16158-001.patch, HADOOP-16158-002.patch,
> HADOOP-16158-003.patch, HADOOP-16158-004.patch
>
>
> Copying blocks in parallel (enabled when blocks per chunk > 0) is a great
> DistCp improvement that can hugely speed up copying big files.
> But its checksum validation is skipped, e.g. in
> `RetriableFileCopyCommand.java`
>
> {code:java}
> if (!source.isSplit()) {
> compareCheckSums(sourceFS, source.getPath(), sourceChecksum,
> targetFS, targetPath);
> }
> {code}
> and this could result in checksum/data mismatch without notifying
> developers/users (e.g. HADOOP-16049).
> I'd like to provide a patch to add the checksum validation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
