elek commented on a change in pull request #632: HDDS-1255. Refactor ozone acceptance test to allow run in secure mode. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/632#discussion_r268396692
########## File path: hadoop-ozone/dist/src/main/smoketest/acommonlib.robot ########## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Oh, I got it. I think you assume it's always executed before all the tests. I would use a generic test initialization file: http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#initialization-files and a 'Suite Setup'. Kinit can be executed in case of the SECURITY_ENABLED is set. An other init file can be added to the s3 directory to initialize the s3 credentials. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
