steveloughran commented on issue #627: HDDS-1299. Support TokenIssuer interface for running jobs with OzoneFileSystem. URL: https://github.com/apache/hadoop/pull/627#issuecomment-476256841 Given this has broken things, can I ask a process question here, specifically regarding Yetus's v-1 > The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. There are lots of ways to test for DTs being ussued: The `hdfs fs` command, the `hadoop dtuils`, the actualyh M * Marshalling/unmarshalling of tokens: org.apache.hadoop.fs.s3a.auth.delegation.TestS3ADelegationTokenSupport * org.apache.hadoop.fs.s3a.auth.delegation.ITestRoleDelegationTokens * org.apache.hadoop.fs.s3a.auth.delegation.ITestRoleDelegationInFileystem * org.apache.hadoop.fs.azurebfs.extensions.ITestAbfsDelegationTokens You can even verify that MR cluster launch collects the tokens: org.apache.hadoop.fs.s3a.auth.delegation.ITestDelegatedMRJob Please. write tests. Apart from the MR job one its straightforward, and I've just given you all the clases to start with. Without tests, when people like myself make an incompatible change which breaks Ozone's DT support, we're just going to shrug and say "well, you should have written the tests"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
