ajayydv commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/634#issuecomment-476384461 > And also we can add few tests to verify the volumeName generated from the newly added function validates with the HddsUtils.verifyResourceName()? So, that in future if someone is changing the logic in this place, it can be caught immediately if it causes any issues. I am open for this but since volume name is not exposed to s3 clients i think it has less value. We test bucket name instead which is already validated in secure-robot test case. Do you still want to verify volume name?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
