steveloughran commented on a change in pull request #628: HADOOP-16186. NPE in
ITestS3AFileSystemContract teardown in DynamoDBMetadataStore.lambda$listChildren
URL: https://github.com/apache/hadoop/pull/628#discussion_r269116472
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestDynamoDBMiscOperations.java
##########
@@ -91,4 +96,17 @@ public void testTranslateWrappedOtherException() throws
Throwable {
assertEquals(e, ex.getCause());
}
+ @Test
+ public void testInnerListChildrenDirectoryNpe() throws Exception {
+ DynamoDBMetadataStore ddbms = new DynamoDBMetadataStore();
+ Path p = mock(Path.class);
+ List<PathMetadata> metas = mock(List.class);
+
+ when(metas.isEmpty()).thenReturn(false);
+ DDBPathMetadata dirPathMeta = null;
+
+ assertEquals(null,
Review comment:
there's an assertNull() for this; switch to that. Don't see a need for text
here as the only text I can think of is "should have been null"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
