noslowerdna commented on a change in pull request #645: HADOOP-16132 Support
multipart download in S3AFileSystem
URL: https://github.com/apache/hadoop/pull/645#discussion_r269699900
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -721,4 +721,24 @@ private Constants() {
* Default change detection require version: true.
*/
public static final boolean CHANGE_DETECT_REQUIRE_VERSION_DEFAULT = true;
+
+ public static final String MULTIPART_DOWNLOAD_ENABLED =
+ "fs.s3a.multipartdownload.enabled";
+ public static final boolean DEFAULT_MULTIPART_DOWNLOAD_ENABLED = false;
+
+ public static final String MULTIPART_DOWNLOAD_PART_SIZE =
+ "fs.s3a.multipartdownload.part-size";
+ public static final long DEFAULT_MULTIPART_DOWNLOAD_PART_SIZE = 8_000_000;
+
+ public static final String MULTIPART_DOWNLOAD_CHUNK_SIZE =
+ "fs.s3a.multipartdownload.chunk-size";
+ public static final long DEFAULT_MULTIPART_DOWNLOAD_CHUNK_SIZE = 262_144;
+
+ public static final String MULTIPART_DOWNLOAD_BUFFER_SIZE =
+ "fs.s3a.multipartdownload.buffer-size";
+ public static final long DEFAULT_MULTIPART_DOWNLOAD_BUFFER_SIZE = 20_000_000;
Review comment:
How did you determine the optimal value for this? Javadoc for it should
specify that the size is "(in bytes)".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
