ben-roling commented on a change in pull request #646: HADOOP-16085: use object
version or etags to protect against inconsistent read after replace/overwrite
URL: https://github.com/apache/hadoop/pull/646#discussion_r269739781
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -696,7 +698,7 @@ public S3AInputPolicy getInputPolicy() {
* @return the change detection policy
*/
@VisibleForTesting
Review comment:
I actually thought a little about this. I was thinking of
`@VisibileForTesting` in this case as documenting this method is only public to
allow access in tests (in a different package). I know it is more typically
used on protected or package-private methods.
I'm curious if there is any feedback about this being public in general?
I'm accessing it across packages in a couple of tests (in the s3guard and
select packages).
I can reinforce that it is only visible for tests by mentioning that
explicitly in the javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
