[ https://issues.apache.org/jira/browse/HADOOP-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803472#comment-16803472 ]
Daniel Templeton commented on HADOOP-16156: ------------------------------------------- [~daryn], that's true. I think the intent here is to clean up latent checkstyle issues that popped up while trying to remove the extraneous null check. Point taken, though. [~shwetayakkali], what I had in mind with my last point above was something like: {code} if ((childnode == null) || (path.length == 1)) { return childnode; } else if (childnode instanceof InnerNode) { return ((InnerNode)childnode).getLoc(path[1]); } else { return null; }{code} > [Clean-up] Remove NULL check before instanceof and fix checkstyle in > InnerNodeImpl > ---------------------------------------------------------------------------------- > > Key: HADOOP-16156 > URL: https://issues.apache.org/jira/browse/HADOOP-16156 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Shweta > Assignee: Shweta > Priority: Minor > Attachments: HADOOP-16156.001.patch, HADOOP-16156.002.patch, > HADOOP-16156.003.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org