hadoop-yetus commented on issue #648: HDDS-1340. Add List Containers API for Recon URL: https://github.com/apache/hadoop/pull/648#issuecomment-477395623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 982 | trunk passed | | +1 | compile | 27 | trunk passed | | +1 | checkstyle | 18 | trunk passed | | +1 | mvnsite | 28 | trunk passed | | +1 | shadedclient | 704 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 58 | trunk passed | | +1 | javadoc | 23 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 30 | the patch passed | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | -0 | checkstyle | 14 | hadoop-ozone/ozone-recon: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | +1 | mvnsite | 24 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 734 | patch has no errors when building and testing our client artifacts. | | -1 | findbugs | 38 | hadoop-ozone/ozone-recon generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 | javadoc | 19 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 29 | ozone-recon in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 2899 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-ozone/ozone-recon | | | Primitive value is boxed and then immediately unboxed in org.apache.hadoop.ozone.recon.spi.impl.ContainerDBServiceProviderImpl.getContainers() At ContainerDBServiceProviderImpl.java:then immediately unboxed in org.apache.hadoop.ozone.recon.spi.impl.ContainerDBServiceProviderImpl.getContainers() At ContainerDBServiceProviderImpl.java:[line 190] | | | org.apache.hadoop.ozone.recon.spi.impl.ContainerDBServiceProviderImpl.getContainers() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead At ContainerDBServiceProviderImpl.java:constructor; use Long.valueOf(long) instead At ContainerDBServiceProviderImpl.java:[line 190] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-648/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/648 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux b003b1a1e32d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9cd6619 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-648/3/artifact/out/diff-checkstyle-hadoop-ozone_ozone-recon.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-648/3/artifact/out/new-findbugs-hadoop-ozone_ozone-recon.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-648/3/testReport/ | | Max. process+thread count | 411 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/ozone-recon U: hadoop-ozone/ozone-recon | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-648/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
