bharatviswa504 commented on a change in pull request #651: HDDS-1339. Implement
ratis snapshots on OM
URL: https://github.com/apache/hadoop/pull/651#discussion_r270634511
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -161,7 +161,10 @@ public TransactionContext startTransaction(
@Override
public long takeSnapshot() throws IOException {
LOG.info("Saving Ratis snapshot on the OM.");
- return ozoneManager.saveRatisSnapshot();
+ if (ozoneManager != null) {
+ return ozoneManager.saveRatisSnapshot();
+ }
+ return 0;
Review comment:
Question: Here we are returning 0,(Should we return the lastAppliedIndex we
are writing) How this will be used by Ratis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
