ben-roling commented on issue #646: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/646#issuecomment-478661480 I can't articulate the exact cause, but I was able to figure out a bit more about how Yetus works and was able to reproduce the patch application failure. GitHub allows a PR to be downloaded as a patch. Yetus uses that [here](https://github.com/apache/yetus/blob/rel/0.9.0/precommit/src/main/shell/test-patch.d/github.sh#L296-L336). This PR can be seen by suffixing the PR URL with ".patch": https://github.com/apache/hadoop/pull/646.patch I downloaded that and when I try to apply it to trunk it fails. I don't know quite why exactly but since it started after I merged trunk back into the branch I'm guessing I will probably need to do a rebase on trunk instead of merging in trunk. At this point I've opened a new PR (#675) with this same content merge-squashed on trunk. Yetus should build it cleanly. I'm closing this PR out, leaving it as-is to leave the review context unchanged for any reviewer that might like to refer back to previous discussions here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
