hadoop-yetus commented on a change in pull request #681: HDDS-1353 : Metrics
scm_pipeline_metrics_num_pipeline_creation_failed keeps increasing because of
BackgroundPipelineCreator.
URL: https://github.com/apache/hadoop/pull/681#discussion_r271467369
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestSCMPipelineManager.java
##########
@@ -208,4 +212,60 @@ public void testPipelineReport() throws IOException {
// clean up
pipelineManager.close();
}
+
+ @Test
+ public void testPipelineCreationFailedMetric() throws Exception {
+ SCMPipelineManager pipelineManager =
+ new SCMPipelineManager(conf, nodeManager, new EventQueue());
+ PipelineProvider mockRatisProvider =
+ new MockRatisPipelineProvider(nodeManager,
+ pipelineManager.getStateManager(), conf);
+ pipelineManager.setPipelineProvider(HddsProtos.ReplicationType.RATIS,
+ mockRatisProvider);
+
+ MetricsRecordBuilder metrics = getMetrics(
+ SCMPipelineMetrics.class.getSimpleName());
+ long numPipelineCreated = getLongCounter("NumPipelineCreated",
+ metrics);
+ Assert.assertTrue(numPipelineCreated == 0);
+
+ // 3 DNs are unhealthy.
+ // Create 5 pipelines (Use up 15 Datanodes)
+ for (int i = 0; i < 5; i++) {
+ Pipeline pipeline = pipelineManager
+ .createPipeline(HddsProtos.ReplicationType.RATIS,
+ HddsProtos.ReplicationFactor.THREE);
+ Assert.assertNotNull(pipeline);
+ }
+
+ metrics = getMetrics(
+ SCMPipelineMetrics.class.getSimpleName());
+ numPipelineCreated = getLongCounter("NumPipelineCreated", metrics);
+ Assert.assertTrue(numPipelineCreated == 5);
+
+ long numPipelineCreateFailed = getLongCounter(
+ "NumPipelineCreationFailed", metrics);
+ Assert.assertTrue(numPipelineCreateFailed == 0);
+
+ //This should fail...
+ try {
+ pipelineManager.createPipeline(HddsProtos.ReplicationType.RATIS,
+ HddsProtos.ReplicationFactor.THREE);
+ Assert.fail();
+ } catch (InsufficientDatanodesException idEx) {
+ Assert.assertEquals(
+ "Cannot create pipeline of factor 3 using 1 nodes.",
+ idEx.getMessage());
+ }
+
+ metrics = getMetrics(
+ SCMPipelineMetrics.class.getSimpleName());
+ numPipelineCreated = getLongCounter("NumPipelineCreated", metrics);
+ Assert.assertTrue(numPipelineCreated == 5);
+
+ numPipelineCreateFailed = getLongCounter(
+ "NumPipelineCreationFailed", metrics);
+ Assert.assertTrue(numPipelineCreateFailed == 0);
+ }
+
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
