hanishakoneru commented on a change in pull request #651: HDDS-1339. Implement 
ratis snapshots on OM
URL: https://github.com/apache/hadoop/pull/651#discussion_r271914300
 
 

 ##########
 File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
 ##########
 @@ -1617,7 +1617,7 @@
 
   <property>
     <name>ozone.om.ratis.snapshot.auto.trigger.threshold</name>
-    <value>400000L</value>
+    <value>400000</value>
 
 Review comment:
   I think 400k should not be too small a number. In HDFS, the default number 
of transactions after which a checkpoint is saved is 1M. Also, the ratis log 
index is not the same as the actual transaction count. There are lot of 
internal ratis log entries also.
   But we can re-tweak the default after some testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to