adoroszlai opened a new pull request #691: [HDDS-1363] ozone.metadata.dirs doesn't pick multiple dirs URL: https://github.com/apache/hadoop/pull/691 ## What changes were proposed in this pull request? `ozone.metadata.dirs` is a global fallback for per-component directory configurations, eg.`ozone.om.db.dirs`, `ozone.scm.db.dirs`, etc. All of these handle only a single location, but values with multiple comma-separated paths (eg. `/data/dir1,/data/dir2`) are treated in different ways: * rejected for the specific configs * used as a single value for the fallback config The goal of this change is to reject comma-separated paths for `ozone.metadata.dirs`, too, by applying the same logic that is already used for the per-component configs. In addition, the following minor fixes are included: 1. Fix error message in `ServerUtils#getDirectoryFromConfig`, which referenced the component name (eg. `SCM`) instead of the config item name (eg. `ozone.om.db.dirs`) as "configuration setting". 2. Move existing test cases for `ServerUtils` to the new `ServerUtilsTest` class from `TestHddsServerUtils` 3. Eliminate duplicated logic in `ScmUtils.getDBPath`, reuse `ServerUtils#getDirectoryFromConfig` https://issues.apache.org/jira/browse/HDDS-1363 ## How was this patch tested? Unit tests (new and existing). Tested manually using `ozone` docker-compose setup.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
