mukul1987 commented on a change in pull request #682: HDDS-1372.
getContainerWithPipeline for a standalone pipeline fails with
ConcurrentModificationException.
URL: https://github.com/apache/hadoop/pull/682#discussion_r272278218
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestSCMContainerManager.java
##########
@@ -194,6 +197,49 @@ public void testGetContainerWithPipeline() throws
Exception {
Assert.assertTrue(replicaNodes.contains(dn1));
}
+ @Test
+ public void testGetContainerReplicaWithParallelUpdate() throws Exception {
+ testGetContainerWithPipeline();
+ final Optional<ContainerID> id = containerManager.getContainerIDs()
+ .stream().findFirst();
+ Assert.assertTrue(id.isPresent());
+ final ContainerID cId = id.get();
+ final Optional<ContainerReplica> replica = containerManager
+ .getContainerReplicas(cId).stream().findFirst();
+ Assert.assertTrue(replica.isPresent());
+ final ContainerReplica cReplica = replica.get();
+ final AtomicBoolean runUpdaterThread =
+ new AtomicBoolean(true);
+
+ Thread updaterThread = new Thread(() -> {
+ while (runUpdaterThread.get()) {
+ try {
+ containerManager.removeContainerReplica(cId, cReplica);
+ containerManager.updateContainerReplica(cId, cReplica);
+ } catch (ContainerNotFoundException e) {
+ e.printStackTrace();
Review comment:
This should be changed to an Assert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
