hadoop-yetus commented on issue #708: HDDS-1401. Static ContainerCache in Datanodes can result in overwrite of container db. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/708#issuecomment-480989978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for branch | | +1 | mvninstall | 1024 | trunk passed | | +1 | compile | 968 | trunk passed | | +1 | checkstyle | 180 | trunk passed | | +1 | mvnsite | 121 | trunk passed | | +1 | shadedclient | 991 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 95 | trunk passed | | +1 | javadoc | 83 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for patch | | +1 | mvninstall | 94 | the patch passed | | +1 | compile | 906 | the patch passed | | +1 | javac | 906 | the patch passed | | +1 | checkstyle | 181 | the patch passed | | +1 | mvnsite | 103 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 615 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 59 | hadoop-hdds/container-service generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | javadoc | 88 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 73 | container-service in the patch failed. | | +1 | unit | 109 | server-scm in the patch passed. | | -1 | unit | 1382 | integration-test in the patch failed. | | +1 | asflicense | 49 | The patch does not generate ASF License warnings. | | | | 7190 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-hdds/container-service | | | org.apache.hadoop.ozone.container.common.utils.ContainerCache.removeLRU(AbstractLinkedMap$LinkEntry) does not release lock on all exception paths At ContainerCache.java:on all exception paths At ContainerCache.java:[line 110] | | Failed junit tests | hadoop.ozone.TestMiniChaosOzoneCluster | | | hadoop.ozone.container.common.impl.TestContainerPersistence | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/708 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 6cfaff448837 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 69e3745 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/artifact/out/new-findbugs-hadoop-hdds_container-service.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/testReport/ | | Max. process+thread count | 4009 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-708/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
