[ 
https://issues.apache.org/jira/browse/HADOOP-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814271#comment-16814271
 ] 

Brahma Reddy Battula commented on HADOOP-15602:
-----------------------------------------------

This can be good enchancement when security is enabled.
{quote}I'm not sure there's benefit to using a custom callq and scheduler etc 
since those are predicated on weighting users.  The user isn't known until the 
auth completes so everything is prio 0 and a fair call queue is a no-op.
{quote}
Yes, As of now this custom and fair callQueue might not benfit here. Anyway by 
Default it will use linkedBlocking Queue

 

Changes are lgtm apart from following suggestion.

It's better to log the "namespace" also so that we can diffenraite whether it's 
from SASL or normal. 
{code:java}
LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
 maxQueueSize + " scheduler: " + schedulerClass);

{code}
[~daryn], if you get chance, can you look once..?

> Support SASL Rpc request handling in separate Handlers 
> -------------------------------------------------------
>
>                 Key: HADOOP-15602
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15602
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Major
>         Attachments: HADOOP-15602.01.patch, HADOOP-15602.02.patch, 
> HADOOP-15602.04.patch
>
>
> Right now, during RPC Connection establishment, all SASL requests are 
> considered as OutOfBand requests and handled within the same Reader thread.
> SASL handling involves authentication with Kerberos and SecretManagers(for 
> Token validation). During this time, Reader thread would be blocked, hence 
> blocking all the incoming RPC requests on other established connections. Some 
> secretManager impls require to communicate to external systems (ex: ZK) for 
> verification.
> SASL RPC handling in separate dedicated handlers, would enable Reader threads 
> to read RPC requests from established connections without blocking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to