arp7 commented on a change in pull request #715: HDDS-1370. Command Execution
in Datanode fails becaue of NPE
URL: https://github.com/apache/hadoop/pull/715#discussion_r274065343
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/datanode/RunningDatanodeState.java
##########
@@ -86,7 +86,16 @@ public void execute(ExecutorService executor) {
for (EndpointStateMachine endpoint : connectionManager.getValues()) {
Callable<EndpointStateMachine.EndPointStates> endpointTask
= getEndPointTask(endpoint);
- ecs.submit(endpointTask);
+ if (endpointTask != null) {
+ ecs.submit(endpointTask);
+ } else {
+ // This can happen if a task is taking more time than the timeOut
+ // specified for the task in await, and when it is completed the task
+ // has set the state to Shutdown, we may see the state as shutdown
+ // here. So, we need to Shutdown DatanodeStateMachine.
+ LOG.error("State is Shutdown in RunningDatanodeState");
+ context.setState(DatanodeStateMachine.DatanodeStates.SHUTDOWN);
Review comment:
I don't fully understand... unfortunately this existing stateContext logic
is 10x more complex than it needs to be.
However I think setting the state to SHUTDOWN should be safe so I will +1
the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
