bharatviswa504 commented on a change in pull request #724: HDDS-1376. Datanode
exits while executing client command when scmId is null
URL: https://github.com/apache/hadoop/pull/724#discussion_r275043940
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
##########
@@ -107,7 +107,6 @@ public void create(VolumeSet volumeSet,
VolumeChoosingPolicy
Preconditions.checkNotNull(volumeChoosingPolicy, "VolumeChoosingPolicy " +
"cannot be null");
Preconditions.checkNotNull(volumeSet, "VolumeSet cannot be null");
- Preconditions.checkNotNull(scmId, "scmId cannot be null");
Review comment:
Why do we need to remove these checks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
