steveloughran commented on a change in pull request #716: HADOOP-16205
Backporting ABFS driver from trunk to branch 2.0
URL: https://github.com/apache/hadoop/pull/716#discussion_r275091436
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java
##########
@@ -75,14 +83,11 @@ public void testBuilderAppendToEmptyFile() throws
Throwable {
@Test
public void testAppendNonexistentFile() throws Throwable {
+ //expected
try {
- FSDataOutputStream out = getFileSystem().append(target);
- //got here: trouble
- out.close();
- fail("expected a failure");
- } catch (Exception e) {
- //expected
- handleExpectedException(e);
+ getFileSystem().append(target).close();
+ } catch (Exception ex) {
Review comment:
this removes the entire failure path of the test: The assertion that
appending to a nonexistent file raises an error. Why did you make this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
