steveloughran commented on issue #716: HADOOP-16205 Backporting ABFS driver from trunk to branch 2.0 URL: https://github.com/apache/hadoop/pull/716#issuecomment-482759642 -1 as is I'm not worried about the abfs changes itself: that's what the testing is for. I've been more reviewing the changes outside the hadoop-azure module as that's where the risk of side effects is hightest. * There's some stuff on Erasure Coding (see Ls) which seems spurious and is mostly commented out anyway. * `AbstractContractAppendTest` needs HADOOP-15744 applied to it * The move away from `intercept()` in the tests means that they aren't actually stressing things (e.g AbstractContractConcatTest) I can see why you've tried to move off intercept(), with java 8 as the target language, but the method can be used with Callable<> operations so does work with java 7. In fact, we started adding it for java 7 [HADOOP-13716](https://issues.apache.org/jira/browse/HADOOP-13716). If you move back to the intercept calls, you can use intellij to convert the l-expressions to Callables at the click of a mouse (one caveat: needs to think the language is java 8 still, so you have to do it before changing the language version to java 7)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
