[
https://issues.apache.org/jira/browse/HADOOP-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817590#comment-16817590
]
Masatake Iwasaki edited comment on HADOOP-13327 at 4/15/19 6:45 AM:
--------------------------------------------------------------------
[[email protected]], thanks for working on this.
I have some feedback of contract tests after I applied
[https://github.com/apache/hadoop/pull/575.patch] .
testHSync against pseudo-distributed HDFS worked fine.
testHSync against WASB failed.
hadoop-tools/hadoop-azure/src/test/resources/abfs.xml should be fixed too.
{code:java}
[INFO] Running
org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate
[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.267
s <<< FAILURE! - in
org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate
[ERROR]
testHSync(org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate)
Time elapsed: 0.119 s <<< FAILURE!
java.lang.AssertionError: hflush support expected:<false> but was:<true>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at
org.apache.hadoop.fs.contract.AbstractContractCreateTest.testHSync(AbstractContractCreateTest.java:355)
...
{code}
Splitting the patch by project-wise (common, aws, azure) would make reviewing
easier if you like.
was (Author: iwasakims):
[[email protected]], thanks for working on this.
I have some feedback of contract tests after I applied
https://github.com/apache/hadoop/pull/575.patch .
testHSync against pseudo-distributed HDFS worked fine.
testHSync against WASB failed.
hadoop-tools/hadoop-azure/src/test/resources/abfs.xml should be fixed too.
{code}
[INFO] Running
org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate
[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.267
s <<< FAILURE! - in
org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate
[ERROR]
testHSync(org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractCreate)
Time elapsed: 0.119 s <<< FAILURE!
java.lang.AssertionError: hflush support expected:<false> but was:<true>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at
org.apache.hadoop.fs.contract.AbstractContractCreateTest.testHSync(AbstractContractCreateTest.java:355)
...
{code}
Splitting the patch by project-wise (common, s3, azure) would make reviewing
easier if you like.
> Add OutputStream + Syncable to the Filesystem Specification
> -----------------------------------------------------------
>
> Key: HADOOP-13327
> URL: https://issues.apache.org/jira/browse/HADOOP-13327
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Attachments: HADOOP-13327-002.patch, HADOOP-13327-003.patch,
> HADOOP-13327-branch-2-001.patch
>
>
> Write down what a Filesystem output stream should do. While core the API is
> defined in Java, that doesn't say what's expected about visibility,
> durability, etc —and Hadoop Syncable interface is entirely ours to define.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
