mukul1987 commented on a change in pull request #718: HDDS-1301. Optimize 
recursive ozone filesystem apis
URL: https://github.com/apache/hadoop/pull/718#discussion_r275340555
 
 

 ##########
 File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStore.java
 ##########
 @@ -120,6 +120,48 @@
                          Table<KEY, VALUE> source, Table<KEY, VALUE> dest)
       throws IOException;
 
+  /**
+   * Moves a key from the Source Table to the destination Table.
+   *
+   * @param key - Key to move.
+   * @param source - Source Table.
+   * @param dest - Destination Table.
+   * @throws IOException on Failure
+   */
+  <KEY, VALUE> void moveWithBatch(KEY key, Table<KEY, VALUE> source,
+      Table<KEY, VALUE> dest, BatchOperation batch) throws IOException;
+
+  /**
+   * Moves a key from the Source Table to the destination Table and updates the
+   * destination to the new value.
+   *
+   * @param key - Key to move.
+   * @param value - new value to write to the destination table.
+   * @param source - Source Table.
+   * @param dest - Destination Table.
+   * @throws IOException on Failure
+   */
+  <KEY, VALUE> void moveWithBatch(KEY key, VALUE value, Table<KEY, VALUE> 
source,
 
 Review comment:
   There are no users of this function, can this be deleted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to