steveloughran commented on issue #743: HADOOP-11452 make rename/3 public URL: https://github.com/apache/hadoop/pull/743#issuecomment-483529621 Pushed up new version which does a lot more w.r.t testing, including updating `FSMainOperationsBaseTest` to java7/8 and implementing an S3A subclass (which fails, see below) Also adds an override point to make it possible for FSs to implement their exception-raising rename after the common semantics checks. I'm not comfortable with that design; I think it'd be better to pull the rename preconditions into some standalone class which takes a src & dest FS status and path strings, and do the checks there where they can validated in isolation. S3A would just precalculate those and then reuse them later on. Be easier for testing too. but...that doesn't help abfs so much, does it? ``` [ERROR] testWorkingDirectory(org.apache.hadoop.fs.contract.s3a.ITestS3AFSMainOperations) Time elapsed: 3.305 s <<< FAILURE! java.lang.AssertionError: expected:<s3a://hwdev-steve-new/ITestS3AFSMainOperations/test> but was:<> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.hadoop.fs.FSMainOperationsBaseTest.testWorkingDirectory(FSMainOperationsBaseTest.java:162) [ERROR] testCopyToLocalWithUseRawLocalFileSystemOption(org.apache.hadoop.fs.contract.s3a.ITestS3AFSMainOperations) Time elapsed: 1.291 s <<< ERROR! java.io.IOException: Mkdirs failed to create /ITestS3AFSMainOperations at org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:317) at org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:305) at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1111) at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1000) at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:988) at org.apache.hadoop.fs.FSMainOperationsBaseTest.writeFile(FSMainOperationsBaseTest.java:1042) at org.apache.hadoop.fs.FSMainOperationsBaseTest.testCopyToLocalWithUseRawLocalFileSystemOption(FSMainOperationsBaseTest.java:1033) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
