swagle commented on issue #745: HDDS-1441. Remove usage of getRetryFailureException. (swagle) URL: https://github.com/apache/hadoop/pull/745#issuecomment-483774084 Thanks, @bshashikant for your review comments. Updated the patch with suggested changes. Although, wouldn't it be better to have a generic exception class in Ratis that can have derived classes on the server side? It would allow separation of concerns for server and client vs now any new type exception will break the client side code in at runtime. Its not like we are doing anything with the exception, only wrapping it up.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
