kittinanasi commented on a change in pull request #713: HDDS-1192. Support
-conf command line argument in GenericCli
URL: https://github.com/apache/hadoop/pull/713#discussion_r276615324
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
##########
@@ -161,6 +157,8 @@ public void start(Object service) {
OzoneConfiguration.activate();
if (service instanceof Configurable) {
conf = new OzoneConfiguration(((Configurable) service).getConf());
+ } else {
Review comment:
This is a good idea, I simplified this part, but I introduced a
setConfiguration method here as well so that I don't have to modify
MiniOzoneCluster that much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
