[ 
https://issues.apache.org/jira/browse/HADOOP-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821206#comment-16821206
 ] 

Erik Krogen commented on HADOOP-16265:
--------------------------------------

Hey [~starphin], this is a good catch. It looks like [~csun] and I missed this 
when doing HDFS-14346. Would it not be simpler to just do:
{code}
return returnUnit.convert(defaultValue, defaultUnit);
{code}

> Configuration#getTimeDuration is not consistent between default value and 
> manual settings.
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-16265
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16265
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: star
>            Priority: Major
>         Attachments: HDFS-14436.001.patch
>
>
> When call getTimeDuration like this:
> {quote}conf.getTimeDuration("nn.interval", 10, 
> TimeUnit.{color:#9876aa}SECONDS{color}{color:#cc7832}, 
> {color}TimeUnit.{color:#9876aa}MILLISECONDS{color}){color:#cc7832};{color}
> {quote}
>  {color:#333333}If "nn.interval" is set manually or configured in xml file, 
> 10000 will be retrurned.{color}
>  If not, 10 will be returned while 10000 is expected. 
>  The logic is not consistent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to