bshashikant commented on a change in pull request #749: HDDS-1395. Key write
fails with BlockOutputStream has been closed exception
URL: https://github.com/apache/hadoop/pull/749#discussion_r277983703
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/CommitWatcher.java
##########
@@ -188,7 +188,6 @@ void releaseBuffersOnException() {
*/
public XceiverClientReply watchForCommit(long commitIndex)
throws IOException {
- Preconditions.checkState(!commitIndex2flushedDataMap.isEmpty());
Review comment:
This was done to address HDDS-1436. watchForCommit is public API which can
be called independently in tests for invalid commitIndexes as well irrespective
of whether the commitIndrxFlushMap contains the log entry or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
