steveloughran commented on a change in pull request #774: HADOOP-16256:
HTTPFileSystem disallows users from configuring the connectionTimeout and
readTimeout of HttpClient
URL: https://github.com/apache/hadoop/pull/774#discussion_r278899372
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/http/TestHttpFileSystem.java
##########
@@ -64,4 +65,38 @@ public void testHttpFileSystem() throws IOException,
URISyntaxException,
assertEquals("/foo", req.getPath());
}
}
+
+ @Test(expected = IllegalStateException.class)
+ public void testHttpFileSystemWithNegativeHttpConnectTimeout() throws
Exception {
+ URI mockURI = new URI("dummyURI");
+
+ Configuration conf = new Configuration(false);
+ conf.set("fs.http.impl", HttpFileSystem.class.getCanonicalName());
+ conf.set("yarn.nodemanager.localizer.http.connect.timeout.ms", "-1");
Review comment:
use the values set in `HttpFileSystemConstants`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
