hadoop-yetus commented on issue #772: HDDS-1468. Inject configuration values to 
Java objects
URL: https://github.com/apache/hadoop/pull/772#issuecomment-487036271
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 32 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 4 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 59 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1152 | trunk passed |
   | +1 | compile | 89 | trunk passed |
   | +1 | checkstyle | 31 | trunk passed |
   | +1 | mvnsite | 77 | trunk passed |
   | -1 | shadedclient | 264 | branch has errors when building and testing our 
client artifacts. |
   | -1 | findbugs | 16 | common in trunk failed. |
   | -1 | findbugs | 26 | server-scm in trunk failed. |
   | -1 | javadoc | 26 | common in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | -1 | mvninstall | 27 | common in the patch failed. |
   | -1 | mvninstall | 20 | server-scm in the patch failed. |
   | +1 | compile | 80 | the patch passed |
   | +1 | javac | 80 | the patch passed |
   | +1 | checkstyle | 30 | the patch passed |
   | -1 | mvnsite | 23 | server-scm in the patch failed. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 627 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | findbugs | 19 | server-scm in the patch failed. |
   | -1 | javadoc | 40 | hadoop-hdds_common generated 1 new + 0 unchanged - 0 
fixed = 1 total (was 0) |
   | -1 | javadoc | 21 | hadoop-hdds_server-scm generated 6 new + 5 unchanged - 
0 fixed = 11 total (was 5) |
   ||| _ Other Tests _ |
   | +1 | unit | 78 | common in the patch passed. |
   | -1 | unit | 24 | server-scm in the patch failed. |
   | +1 | asflicense | 34 | The patch does not generate ASF License warnings. |
   | | | 3007 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/772 |
   | Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall 
 mvnsite  unit  shadedclient  findbugs  checkstyle  |
   | uname | Linux 42a19cb93db1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c35abcd |
   | maven | version: Apache Maven 3.3.9 |
   | Default Java | 1.8.0_191 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_common.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-javadoc-hadoop-hdds_common.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_common.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt
 |
   | mvnsite | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_common.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_server-scm.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/testReport/ |
   | Max. process+thread count | 445 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/console |
   | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to