steveloughran commented on a change in pull request #666: HADOOP-16221 add
option to fail operation on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#discussion_r279118899
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Retries.java
##########
@@ -26,11 +26,23 @@
import org.apache.hadoop.classification.InterfaceStability;
/**
- * Declaration of retry policy for documentation only.
- * This is purely for visibility in source and is currently package-scoped.
- * Compare with {@link org.apache.hadoop.io.retry.AtMostOnce}
- * and {@link org.apache.hadoop.io.retry.Idempotent}; these are real
- * markers used by Hadoop RPC.
+ * <p>
+ * Annotations to inform the caller of an annotated method whether
Review comment:
Yes, though I'd be stricter about the wrapping of retries. You mustn't retry
around a retrying operation as you'll just cause things to take so long that
operations will time out anyway. The raw/translated flags are markers about
whether to expect AWS-library Runtime Exceptions or translated stuff, or a
mixture. It's less critical, but once everything is pure IOE, there's no need
to catch and convert again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
