arp7 commented on a change in pull request #781: HDDS-1473. DataNode ID file
should be human readable.
URL: https://github.com/apache/hadoop/pull/781#discussion_r279547571
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneCluster.java
##########
@@ -132,6 +134,13 @@ public void testDatanodeIDPersistent() throws Exception {
File validIdsFile = new File(WRITE_TMP, "valid-values.id");
validIdsFile.delete();
ContainerUtils.writeDatanodeDetailsTo(id1, validIdsFile);
+ // Validate using yaml parser
+ Yaml yaml = new Yaml();
+ try {
+ yaml.load(new FileReader(validIdsFile));
+ } catch (Exception e) {
Review comment:
Why not just let the exception bubble up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
