hadoop-yetus commented on a change in pull request #743: HADOOP-11452 make rename/3 public URL: https://github.com/apache/hadoop/pull/743#discussion_r279596426
########## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md ########## @@ -1046,21 +1046,33 @@ removes the path and all descendants * Object Stores and other non-traditional filesystems onto which a directory tree is emulated, tend to implement `delete()` as recursive listing and entry-by-entry delete operation. -This can break the expectations of client applications for O(1) atomic directory +This can break the expectations of client applications for `O(1)` atomic directory deletion, preventing the stores' use as drop-in replacements for HDFS. ### `boolean rename(Path src, Path d)` In terms of its specification, `rename()` is one of the most complex operations within a filesystem . In terms of its implementation, it is the one with the most ambiguity regarding when to return false -versus raising an exception. +versus raising an exception. This makes less useful to use than +others: in production code it is usually wrapped by code to raise an Review comment: whitespace:end of line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
