[
https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829977#comment-16829977
]
Da Zhou commented on HADOOP-15616:
----------------------------------
Unfortunately, there is no easy way to determine thread pool size, as mentioned
above there are too many factors to consider. In ABFS those numbers are tuned
based on lots of stress tests and benchmarks(TeraSort, TPC, etc ). But before
tuning the numbers for COS you might want to use profiling tools to get more
insights, sometimes the size of thread pool is not the bottleneck for
performance.
I also took a quick view on this patch, some comments:
1. imports should avoid ***
2. import ordering should be: (copied from Steve's comments for ABFS :D )
{code:java}
java.*
javax.*
other.*
org.apache.*
statics {code}
3. A few comments are written in Chinese, please replace them with English to
avoid confusion for other reviewers.
> Incorporate Tencent Cloud COS File System Implementation
> --------------------------------------------------------
>
> Key: HADOOP-15616
> URL: https://issues.apache.org/jira/browse/HADOOP-15616
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/cos
> Reporter: Junping Du
> Assignee: YangY
> Priority: Major
> Attachments: HADOOP-15616.001.patch, HADOOP-15616.002.patch,
> HADOOP-15616.003.patch, HADOOP-15616.004.patch, HADOOP-15616.005.patch,
> HADOOP-15616.006.patch, HADOOP-15616.007.patch, HADOOP-15616.008.patch,
> HADOOP-15616.009.patch, Junping Du.url, Tencent-COS-Integrated-v2.pdf,
> Tencent-COS-Integrated.pdf
>
>
> Tencent cloud is top 2 cloud vendors in China market and the object store COS
> （[https://intl.cloud.tencent.com/product/cos]） is widely used among China’s
> cloud users but now it is hard for hadoop user to access data laid on COS
> storage as no native support for COS in Hadoop.
> This work aims to integrate Tencent cloud COS with Hadoop/Spark/Hive, just
> like what we do before for S3, ADL, OSS, etc. With simple configuration,
> Hadoop applications can read/write data from COS without any code change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
