brkyvz commented on a change in pull request #768: HADOOP-16269. ABFS: add 
listFileStatus with StartFrom.
URL: https://github.com/apache/hadoop/pull/768#discussion_r280569035
 
 

 ##########
 File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
 ##########
 @@ -522,15 +537,38 @@ public FileStatus getFileStatus(final Path path) throws 
IOException {
             eTag);
   }
 
+  /**
+   * @param path The list path.
+   * @return the entries in the path.
+   * */
   public FileStatus[] listStatus(final Path path) throws IOException {
-    LOG.debug("listStatus filesystem: {} path: {}",
+    return listStatus(path, null);
+  }
+
+  /**
+   * @param path Path the list path.
+   * @param startFrom the entry name that list results should start with.
 
 Review comment:
   Could you give an example of `startFrom` please? From the tests it seems 
like the `startFrom` is supposed to be a relative name within `path`?
   Should this API be called like:
   ```java
   listStatus("/some-folder", "file-in-folder")
   listStatus("/some-folder", "file-in")
   ```
   or
   ```java
   listStatus("/some-folder", "/some-folder/file-in-folder")
   listStatus("/some-folder", "/some-folder/file-in")
   ```
   from the test cases it seems like the former.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to