[ 
https://issues.apache.org/jira/browse/HADOOP-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832679#comment-16832679
 ] 

Chen Liang commented on HADOOP-16292:
-------------------------------------

This is just minor refactoring so I think it is okay to not have new unit test. 
I have committed v001 patch to trunk. Thanks for the contribution [~zhengxg3]!

> Refactor checkTrustAndSend in SaslDataTransferClient to make it cleaner  
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-16292
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16292
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sherwood Zheng
>            Assignee: Sherwood Zheng
>            Priority: Major
>         Attachments: HADOOP-16292.001.patch
>
>
> Right now
> private IOStreamPair checkTrustAndSend(InetAddress addr,
>  OutputStream underlyingOut, InputStream underlyingIn,
>  DataEncryptionKeyFactory encryptionKeyFactory,
>  Token<BlockTokenIdentifier> accessToken, DatanodeID datanodeId)
> only provide an API without secretKey paramter for 
> checkTrustAndSend(
>  InetAddress addr, OutputStream underlyingOut, InputStream underlyingIn,
>  DataEncryptionKeyFactory encryptionKeyFactory,
>  Token<BlockTokenIdentifier> accessToken, DatanodeID datanodeId,
>  SecretKey secretKey)
> Remove the former API to make it cleaner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to