[
https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064057#comment-13064057
]
Suresh Srinivas commented on HADOOP-7399:
-----------------------------------------
Early comments:
Comments:
# Please add javadoc to ClientCall constructor. Some of the parameters in
method javadoc is missing description as well.
# Should ClentCall#responseClass be final? Also should we consider making some
of the methods that are not expected to be overridden by subclasses, final?
# Should ClientCall#setException() be called, readException*(). Also is the
IOException that is thrown, the exception read from the DataInputStream. If so
can you add that to javadoc.
# Since ClientCall has error member, should it also have value member? You
could have read
# Please add @Override to methods
# WritableRpcCall#setException() should call ClientCall#setException() instead
of duplicating the code.
I will continue to review it.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on
> Writable. I think this will be an important step towards making an RpcEngine
> truly configurable, without having to use tunnel protocols as in case of
> AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
