ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-490659830 The latest commit fixes the test failures I was seeing against a bucket with versioning disabled. In the (etag,client) case for `testRenameEventuallyConsistentFile`, stubbing of inconsistent responses from AmazonS3.copyObject() was incorrect. For that case we should never see a "precondition failed" response since we don't pass any eTag or versionId qualification on the request. There were a few other failures in test methods that require versioning since I hadn't copied the code that executes the assumption to make sure versioning is there. I ran the full ITestS3ARemoteFileChanged once each against a bucket with versioning enabled and a bucket with versioning disabled and all tests either succeeded or were skipped as expected. I will run the full test suite again against a bucket with versioning disabled just in case there are somehow other failures to uncover there since previously I only ran the suite against a bucket with versioning _enabled_.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
