hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification URL: https://github.com/apache/hadoop/pull/804#issuecomment-490999735 This patch requires more changes (after HDDS-1491 which fixes seek operation). 1. In BlockInputStream#seek(), it is not sufficient to just check if the required chunkIndex matches with current buffers chunk index and that the buffer has data remaining. Since the buffer might have only a partial chunk, it is possible that it does not cover the position seeked. 2. In BlockInputStream#readChunkFromContainer(), we should not blindly increment the chunkIndex. The last read might have read only a part of the chunk and the next read may be required to read from the same chunk again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
