ajfabbri commented on a change in pull request #787: HADOOP-16251. ABFS: add FSMainOperationsBaseTest URL: https://github.com/apache/hadoop/pull/787#discussion_r282611587
########## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemMainOperation.java ########## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs; + +import org.junit.Ignore; + +import org.apache.hadoop.fs.FSMainOperationsBaseTest; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.azurebfs.contract.ABFSContractTestBinding; + +/** + * Test AzureBlobFileSystem main operations. + * */ +public class ITestAzureBlobFileSystemMainOperation extends FSMainOperationsBaseTest { + + private static final String TEST_ROOT_DIR = + "/tmp/TestAzureBlobFileSystemMainOperations"; + + private final ABFSContractTestBinding binding; + + public ITestAzureBlobFileSystemMainOperation () throws Exception { + super(TEST_ROOT_DIR); + // Note: There are shared resources in this test suite (eg: "test/new/newfile") + // To make sure this test suite can be ran in parallel, different containers + // will be used for each test. + binding = new ABFSContractTestBinding(false); + } + + @Override + public void setUp() throws Exception { + binding.setup(); + fSys = binding.getFileSystem(); + } + + @Override + public void tearDown() throws Exception { + // Note: Because "tearDown()" is called during the testing, + // here we should not call binding.tearDown() to destroy the container. + // Instead we should remove the test containers manually with + // AbfsTestUtils. + super.tearDown(); + } + + @Override + protected FileSystem createFileSystem() throws Exception { + return fSys; + } + + @Override + @Ignore("Permission check for getFileInfo doesn't match the HdfsPermissionsGuide") + public void testListStatusThrowsExceptionForUnreadableDir() { + // Permission Checks: + // https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsPermissionsGuide.html + } + Review comment: The Ignore annotation says getFileInfo.. I would have thought you wanted the getListing row in the permission chart? ```getListing NO N/A N/A READ, EXECUTE``` which is READ | EXECUTE on the final part of the path (dir). T thought that was what this test case was checking? I'm +1 on the patch but you should update the Ignore comment if it is indeed getListing that should be checked here. If this behavioir is unique to the ABFS service that's ok we should just document it as such. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
