elek commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#discussion_r283688185
########## File path: Dockerfile ########## @@ -36,7 +36,9 @@ RUN chown hadoop /opt ADD scripts /opt/ ADD scripts/krb5.conf /etc/ RUN yum install -y krb5-workstation - +RUN mkdir -p /etc/hadoop && mkdir -p /var/log/hadoop && chmod 777 /etc/hadoop && chmod 777 /var/log/hadoop +ENV HADOOP_LOG_DIR=/var/log/hadoop +ENV HADOOP_CONF_DIR=/etc/hadoop Review comment: Thanks @wyanghwx the comment. I think your opinion is under discussion at https://issues.apache.org/jira/browse/HDDS-1495 and personally I am convinced yet. But this patch doesn't introduce any new method just fixes a small bug in the existing practice (which is not preferred by you) Do you prefer to stop all the bugfixing until we got an agreement in HDDS-1495? Do you agree to commit this patch because it's required in the current situation? Do you see any technical problems with applying this patch? ps: here is a comment: https://lists.apache.org/thread.html/e5c17f08f30aa924bdfd50d215b3f468269dc9198411b069d035a891@%3Cgeneral.incubator.apache.org%3E > The main Docker Hub at hub.docker.com is a public-facing downstream distribution channel -- similar to Maven Central, PyPI, Debian package management, etc. > It is appropriate to distribute official releases through downstream channels, but inappropriate to distribute unreleased materials through them. (That's why having `latest` on hub.docker.com point to git `master` is problematic.) This is what we are doing right now. We are distributing existing releases via downstream channels. And finally, I kindly ask to continue the discussion about the current docker practices in HDDS-1495 and don't start the same conversation everywhere. I propose it just because it can be easier to follow and manage. Does it work for you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
