swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284480391
########## File path: hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java ########## @@ -0,0 +1,172 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.tasks; + +import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_DB_DIRS; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import java.io.File; +import java.util.Collections; + +import org.apache.commons.lang3.tuple.ImmutablePair; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.recon.persistence.AbstractSqlDatabaseTest; +import org.apache.hadoop.ozone.recon.recovery.ReconOMMetadataManager; +import org.apache.hadoop.ozone.recon.recovery.ReconOmMetadataManagerImpl; +import org.hadoop.ozone.recon.schema.ReconInternalSchemaDefinition; +import org.hadoop.ozone.recon.schema.tables.daos.ReconTaskStatusDao; +import org.hadoop.ozone.recon.schema.tables.pojos.ReconTaskStatus; +import org.jooq.Configuration; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +/** + * Class used to test ReconTaskControllerImpl. + */ +public class TestReconTaskControllerImpl extends AbstractSqlDatabaseTest { + + private ReconTaskController reconTaskController; + + private Configuration sqlConfiguration; + @Before + public void setUp() throws Exception { + + File omDbDir = temporaryFolder.newFolder(); + OzoneConfiguration ozoneConfiguration = new OzoneConfiguration(); + ozoneConfiguration.set(OZONE_OM_DB_DIRS, omDbDir.getAbsolutePath()); + ReconOMMetadataManager omMetadataManager = new ReconOmMetadataManagerImpl( + ozoneConfiguration); + + sqlConfiguration = getInjector() + .getInstance(Configuration.class); + + ReconInternalSchemaDefinition schemaDefinition = getInjector(). + getInstance(ReconInternalSchemaDefinition.class); + schemaDefinition.initializeSchema(); + + reconTaskController = new ReconTaskControllerImpl(ozoneConfiguration, + omMetadataManager, sqlConfiguration); + } + + @Test + public void testRegisterTask() throws Exception { + String taskName = "Dummy_" + System.currentTimeMillis(); + DummyReconDBTask dummyReconDBTask = + new DummyReconDBTask(taskName, DummyReconDBTask.TaskType.ALWAYS_PASS); + reconTaskController.registerTask(dummyReconDBTask); + assertTrue(reconTaskController.getRegisteredTasks().size() == 1); + assertTrue(reconTaskController.getRegisteredTasks() + .get(dummyReconDBTask.getTaskName()) == dummyReconDBTask); + } + + @Test + public void testConsumeOMEvents() throws Exception { + + ReconDBUpdateTask reconDBUpdateTaskMock = mock(ReconDBUpdateTask.class); + when(reconDBUpdateTaskMock.getTablesListeningOn()).thenReturn(Collections + .EMPTY_LIST); + when(reconDBUpdateTaskMock.getTaskName()).thenReturn("MockTask"); + when(reconDBUpdateTaskMock.process(any(OMUpdateEventBatch.class))) + .thenReturn(new ImmutablePair<>("MockTask", true)); + reconTaskController.registerTask(reconDBUpdateTaskMock); + reconTaskController.consumeOMEvents( + new OMUpdateEventBatch(Collections.emptyList())); + + verify(reconDBUpdateTaskMock, times(1)) + .process(any()); + } + + @Test + public void testFailedTaskRetryLogic() throws Exception { + String taskName = "Dummy_" + System.currentTimeMillis(); + DummyReconDBTask dummyReconDBTask = + new DummyReconDBTask(taskName, DummyReconDBTask.TaskType.FAIL_ONCE); + reconTaskController.registerTask(dummyReconDBTask); + + + long currentTime = System.nanoTime(); + OMDBUpdateEvent.EventInfo eventInfoMock = mock( + OMDBUpdateEvent.EventInfo.class); + when(eventInfoMock.getSequenceNumber()).thenReturn(100L); + when(eventInfoMock.getEventTimestampMillis()).thenReturn(currentTime); + + OMUpdateEventBatch omUpdateEventBatchMock = mock(OMUpdateEventBatch.class); + when(omUpdateEventBatchMock.getLastEventInfo()).thenReturn(eventInfoMock); + + reconTaskController.consumeOMEvents(omUpdateEventBatchMock); + assertFalse(reconTaskController.getRegisteredTasks().isEmpty()); + assertEquals(dummyReconDBTask, reconTaskController.getRegisteredTasks() + .get(dummyReconDBTask.getTaskName())); + + ReconTaskStatusDao dao = new ReconTaskStatusDao(sqlConfiguration); + ReconTaskStatus dbRecord = dao.findById(taskName); + + Assert.assertEquals(taskName, dbRecord.getTaskName()); + Assert.assertEquals(Long.valueOf(currentTime), + dbRecord.getLastUpdatedTimestamp()); + Assert.assertEquals(Long.valueOf(100L), dbRecord.getLastUpdatedSeqNumber()); + } + + @Test + public void testBadBehavedTaskBlacklisting() throws Exception { + String taskName = "Dummy_" + System.currentTimeMillis(); + DummyReconDBTask dummyReconDBTask = + new DummyReconDBTask(taskName, DummyReconDBTask.TaskType.ALWAYS_FAIL); + reconTaskController.registerTask(dummyReconDBTask); + + + long currentTime = System.nanoTime(); + OMDBUpdateEvent.EventInfo eventInfoMock = + mock(OMDBUpdateEvent.EventInfo.class); + when(eventInfoMock.getSequenceNumber()).thenReturn(100L); + when(eventInfoMock.getEventTimestampMillis()).thenReturn(currentTime); + + OMUpdateEventBatch omUpdateEventBatchMock = mock(OMUpdateEventBatch.class); + when(omUpdateEventBatchMock.getLastEventInfo()).thenReturn(eventInfoMock); + + for (int i = 0; i < 2; i++) { + reconTaskController.consumeOMEvents(omUpdateEventBatchMock); + + assertFalse(reconTaskController.getRegisteredTasks().isEmpty()); + assertEquals(dummyReconDBTask, reconTaskController.getRegisteredTasks() + .get(dummyReconDBTask.getTaskName())); + } + + //Should be blacklisted now. + reconTaskController.consumeOMEvents( + new OMUpdateEventBatch(Collections.emptyList())); + assertTrue(reconTaskController.getRegisteredTasks().isEmpty()); + + ReconTaskStatusDao dao = new ReconTaskStatusDao(sqlConfiguration); + ReconTaskStatus dbRecord = dao.findById(taskName); + + Assert.assertEquals(taskName, dbRecord.getTaskName()); + Assert.assertEquals(Long.valueOf(0L), dbRecord.getLastUpdatedTimestamp()); + Assert.assertEquals(Long.valueOf(0L), dbRecord.getLastUpdatedSeqNumber()); + } + +} Review comment: newline missing ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
