anuengineer commented on a change in pull request #828: HDDS-1538. Update ozone
protobuf message for ACLs. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/828#discussion_r285335823
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -256,13 +258,13 @@ public void createVolume(String volumeName, VolumeArgs
volArgs)
OzoneQuota.parseQuota(volArgs.getQuota()).sizeInBytes();
List<OzoneAcl> listOfAcls = new ArrayList<>();
//User ACL
- listOfAcls.add(new OzoneAcl(OzoneAcl.OzoneACLType.USER,
+ listOfAcls.add(new OzoneAcl(ACLIdentityType.USER,
Review comment:
There is one small problem here. We (Ozone) is a superclass of POSIX ACLs.
we have world and anonymous access defined differently. World users are still
users we know -- that is we can log the user identity, anonymous is that we
don't know and we don't care. I am not sure ACLIdentityType takes care of that.
A similar comment was made earlier by @xiaoyuyao since the ACLs itself is a
larger group for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
