bshashikant commented on issue #825: HDDS-1449. JVM Exit in datanode while committing a key. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/825#issuecomment-493900456 Thanks @mukul1987 for working on this. The patch overall looks good to me. Some comments : 1) When want to force evict the container cache, it should ideally not check for the reference count to be 0. 2) We should have two methods, one to actually evict the cache forcefully which will not validate the the reference count to be 0 and one which actually validates the reference count to be 0 before removing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
