ajayydv commented on a change in pull request #829: HDDS-1550. MiniOzoneCluster
is not shutting down all the threads during shutdown. Contributed by Mukul
Kumar Singh.
URL: https://github.com/apache/hadoop/pull/829#discussion_r286201065
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -993,6 +995,10 @@ public void stop() {
metrics.unRegister();
}
+ if (ms != null) {
Review comment:
in order of precedence, i think closing scmMetadataStore takes more
precedence than Metrics. Shall we move this close statement to end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
