[ 
https://issues.apache.org/jira/browse/HADOOP-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065972#comment-13065972
 ] 

Kihwal Lee commented on HADOOP-7446:
------------------------------------

Ignore my previous comment. As long as we say only gcc is supported, the macros 
you used are fine. Otherwise letting autoconf decide and drive would have been 
better. 

What I really wanted, but grossly missed in my comment above is letting ant 
determine the target platform and propagate to autoconf and make. Currently 
there are missing elements, but can be addressed in a separate jira.  The ideal 
picture I am imagining is, if a build machine is properly set up, the user 
should be able to build and generate packages for all supported arch and 
platforms by simply telling one or more targets to ant. 

One last thing. Would you shed some light on this comment in the code?
{code}
// alignment doesn't seem to help?
{code}

> Implement CRC32C native code using SSE4.2 instructions
> ------------------------------------------------------
>
>                 Key: HADOOP-7446
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7446
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>            Reporter: Todd Lipcon
>         Attachments: hadoop-7446.txt
>
>
> Once HADOOP-7445 is implemented, we can get further performance improvements 
> by implementing CRC32C using the hardware support available in SSE4.2. This 
> support should be dynamically enabled based on CPU feature flags, and of 
> course should be ifdeffed properly so that it doesn't break the build on 
> architectures/platforms where it's not available.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to