iamcaoxudong commented on a change in pull request #830: HDDS-1530. Freon
support big files larger than 2GB and add --bufferSize and --validateWrites
options.
URL: https://github.com/apache/hadoop/pull/830#discussion_r285991232
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##########
@@ -228,8 +243,20 @@ public Void call() throws Exception {
init(freon.createOzoneConfiguration());
}
- keyValue =
- DFSUtil.string2Bytes(RandomStringUtils.randomAscii(keySize - 36));
+ keyValueBuffer = DFSUtil.string2Bytes(
+ RandomStringUtils.randomAscii(bufferSize));
Review comment:
Thank you for reviewing, but:
1. In the case of not specifying --validateWrites, writing zero or random
data has no difference, because the digest calculation is not involved here,
and just generating a bufferSize (default 4K) of random data is very fast.
2. In the case of specifying --validateWrites, there is no difference
between writing zeros or random data also, because it is necessary to
repeatedly calculate the digest both situations (even if all bytes written are
0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
