hadoop-yetus commented on issue #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#issuecomment-495457257 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 42 | Maven dependency ordering for branch | | +1 | mvninstall | 510 | trunk passed | | +1 | compile | 260 | trunk passed | | +1 | checkstyle | 76 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 866 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 141 | trunk passed | | 0 | spotbugs | 311 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 525 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 518 | the patch passed | | +1 | compile | 273 | the patch passed | | +1 | cc | 273 | the patch passed | | +1 | javac | 273 | the patch passed | | -0 | checkstyle | 40 | hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 2 | The patch has no whitespace issues. | | +1 | shadedclient | 663 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 150 | the patch passed | | -1 | findbugs | 316 | hadoop-ozone generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) | ||| _ Other Tests _ | | -1 | unit | 157 | hadoop-hdds in the patch failed. | | -1 | unit | 111 | hadoop-ozone in the patch failed. | | +1 | asflicense | 42 | The patch does not generate ASF License warnings. | | | | 5174 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-ozone | | | Nullcheck of volumeArgs at line 536 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.addAcl(OzoneObj, OzoneAcl) At VolumeManagerImpl.java:536 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.addAcl(OzoneObj, OzoneAcl) At VolumeManagerImpl.java:[line 536] | | | Nullcheck of volumeArgs at line 581 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.removeAcl(OzoneObj, OzoneAcl) At VolumeManagerImpl.java:581 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.removeAcl(OzoneObj, OzoneAcl) At VolumeManagerImpl.java:[line 581] | | | Nullcheck of volumeArgs at line 627 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.setAcl(OzoneObj, List) At VolumeManagerImpl.java:627 of value previously dereferenced in org.apache.hadoop.ozone.om.VolumeManagerImpl.setAcl(OzoneObj, List) At VolumeManagerImpl.java:[line 627] | | | Return value of java.util.Objects.nonNull(Object) ignored, but method has no side effect At OmOzoneAclMap.java:but method has no side effect At OmOzoneAclMap.java:[line 79] | | | Return value of java.util.Objects.nonNull(Object) ignored, but method has no side effect At OmOzoneAclMap.java:but method has no side effect At OmOzoneAclMap.java:[line 118] | | | Return value of java.util.Objects.nonNull(Object) ignored, but method has no side effect At OmOzoneAclMap.java:but method has no side effect At OmOzoneAclMap.java:[line 105] | | | Return value of java.util.Objects.nonNull(Object) ignored, but method has no side effect At OmOzoneAclMap.java:but method has no side effect At OmOzoneAclMap.java:[line 91] | | Failed junit tests | hadoop.ozone.om.ratis.TestOzoneManagerRatisServer | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/847 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 499c900f01b4 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 460ba7f | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/artifact/out/diff-checkstyle-hadoop-ozone.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/artifact/out/new-findbugs-hadoop-ozone.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/testReport/ | | Max. process+thread count | 445 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-847/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
