ben-roling commented on issue #863: HADOOP-16332. Remove S3A dependency on http core. URL: https://github.com/apache/hadoop/pull/863#issuecomment-496541005 Btw, you may already know this, but httpcore is currently a transitive, provided scope dependency via hadoop-common. Whether it is really needed for anything that hadoop-aws does, I don't really know. There's a good chance it isn't I would guess. Nonetheless, I support the idea of limiting dependencies and have no objection to this change. I wasn't sure about it when I added it in the first place and tried to call it out on one of the reviews but I think it slipped through the cracks. Something else -- org.apache.http.HttpStatus is also included in aws-java-sdk-bundle. I don't know how you feel about making reference to it given that? You could potentially delete the httpcore dependency and still use HttpStatus due to that. It does feel odd to depend on it coming from there though so using an internal constant still feels reasonable. One last thing - ITestS3AConfiguration also refers to org.apache.http.HttpStatus. Do you care to remove that reference as well?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
