elek commented on a change in pull request #860: HDDS-1597. Remove hdds-server-scm dependency from ozone-common URL: https://github.com/apache/hadoop/pull/860#discussion_r288602135
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java ########## @@ -52,6 +51,7 @@ import org.apache.hadoop.test.GenericTestUtils; import org.apache.hadoop.test.LambdaTestUtils; +import org.apache.commons.lang3.RandomStringUtils; Review comment: In this case this is not just a reorder because I replaced the original commons-lang2 transitive dependency with commons-lang3 and the package name is different. But I agree, this is not a fair modification. Let's fix only the dependencies here and don't include additional modification. I fixed it with using the original commons-lang2 (and added the explicit dependency which was used from a transitive dependency until now). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
